Remove automatic tunnel option from GUI and protobuf #7762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-jarvelov
force-pushed
the
remove-automatic-tunnel-option-from-gui-des-1787
branch
from
aeb5072 to
839779a
Compare
MarkusPettersson98
previously approved these changes
Mar 5, 2025
There was a problem hiding this comment.
🔥
Reviewed 1 of 1 files at r1, 17 of 17 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
tobias-jarvelov
force-pushed
the
remove-automatic-tunnel-option-from-gui-des-1787
branch
from
839779a to
53650a5
Compare
MarkusPettersson98
previously approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
MarkusPettersson98
force-pushed
the
remove-automatic-tunnel-option-from-gui-des-1787
branch
from
e5c1d81 to
f5c73d3
Compare
tobias-jarvelov
force-pushed
the
remove-automatic-tunnel-option-from-gui-des-1787
branch
from
f5c73d3 to
98fdb7d
Compare
tobias-jarvelov
force-pushed
the
remove-automatic-tunnel-option-from-gui-des-1787
branch
from
98fdb7d to
44d5378
Compare
MarkusPettersson98
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status:
olmoh
approved these changes
Mar 10, 2025
Also add TRANSLATORS comment to the changed translations.
This way we can use its fallback value if relaySettings.tunnelProtocol is undefined.
Remove "any" as fallback value.
We only used the relaySettings parameter to handle when tunnel protocol was set to "any" to potentially enable "openvpn" endpoints if multihop was not enabled. However, as the tunnel protocol now has to be explicitly assigned to either "wireguard" or "openvpn" we should only enable endpoints which matches the tunnel protocol so we don't need to check the multihop setting, as it has to be disabled for the user to switch the tunnel protocol to "openvpn"
MarkusPettersson98
force-pushed
the
remove-automatic-tunnel-option-from-gui-des-1787
branch
from
44d5378 to
c4d84fc
Compare
MarkusPettersson98
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status:
MarkusPettersson98
deleted the
remove-automatic-tunnel-option-from-gui-des-1787
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DES-1791
This change is