Implement device ip setting #7763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawa
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Reviewed 32 of 32 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
force-pushed
the
implement-device-ip-setting
branch
from
0829a9e to
9eaf979
Compare
Rawa
previously approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:
Pururun
force-pushed
the
implement-device-ip-setting
branch
from
9eaf979 to
e19778d
Compare
Pururun
force-pushed
the
implement-device-ip-setting
branch
from
e19778d to
6d60c9f
Compare
Rawa
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Reviewed 22 of 22 files at r3.
Reviewable status:
Pururun
force-pushed
the
implement-device-ip-setting
branch
from
6d60c9f to
c17b6fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the ability to force the app to use a specific ip version when connecting to a relay.
Fixes: DROID-1827
Fixes: DROID-1826
This change is