Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for verifying version metadata with (one of) multiple keys #7767

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

dlon
Copy link
Member

@dlon dlon commented Mar 6, 2025

Close DES-1802.


This change is Reviewable

Copy link

linear bot commented Mar 6, 2025

@dlon dlon force-pushed the multiple-verifying-keys branch from b8ed9ae to a06c6e5 Compare March 6, 2025 17:11
@dlon dlon requested a review from MarkusPettersson98 March 6, 2025 17:11
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion


mullvad-update/meta/src/platform.rs line 235 at r1 (raw file):

        // TODO: Actual key
        let public_key =
            key::VerifyingKey::from_hex(include_str!("../../test-pubkey")).expect("Invalid pubkey");

TODO: Actual keys* 😊

Code quote:

        // TODO: Actual key
        let public_key =
            key::VerifyingKey::from_hex(include_str!("../../test-pubkey")).expect("Invalid pubkey");

@dlon dlon force-pushed the multiple-verifying-keys branch from afc95a0 to 4ef4d55 Compare March 7, 2025 08:37
Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


mullvad-update/meta/src/platform.rs line 235 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

TODO: Actual keys* 😊

I've replaced this with the stagemole key, since it was inconsistent. But the TODO comment is unnecessary since we have an issue for this.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the multiple-verifying-keys branch from 4ef4d55 to 54dec57 Compare March 7, 2025 09:21
@dlon dlon merged commit cae71a3 into main Mar 7, 2025
52 of 53 checks passed
@dlon dlon deleted the multiple-verifying-keys branch March 7, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants