-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for verifying version metadata with (one of) multiple keys #7767
Conversation
b8ed9ae
to
a06c6e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
mullvad-update/meta/src/platform.rs
line 235 at r1 (raw file):
// TODO: Actual key let public_key = key::VerifyingKey::from_hex(include_str!("../../test-pubkey")).expect("Invalid pubkey");
TODO: Actual keys* 😊
Code quote:
// TODO: Actual key
let public_key =
key::VerifyingKey::from_hex(include_str!("../../test-pubkey")).expect("Invalid pubkey");
afc95a0
to
4ef4d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
mullvad-update/meta/src/platform.rs
line 235 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
TODO: Actual keys* 😊
I've replaced this with the stagemole key, since it was inconsistent. But the TODO comment is unnecessary since we have an issue for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
4ef4d55
to
54dec57
Compare
Close DES-1802.
This change is