Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep native debug symbols for debug builds #7805

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

kl
Copy link
Contributor

@kl kl commented Mar 12, 2025

This will keep the debug symbols when doing debug builds.

This will increase the size of a full debug build (all architectures) APK from about 90 MB to about 400 MB.

Prod APKs are not affected.


This change is Reviewable

@kl kl added the Android Issues related to Android label Mar 12, 2025
Copy link

linear bot commented Mar 12, 2025

@kl kl marked this pull request as ready for review March 12, 2025 15:28
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the improve-native-debugging-experience-droid-1845 branch from 66ddb15 to 4c7560c Compare March 17, 2025 09:52
@Pururun Pururun merged commit 1020775 into main Mar 17, 2025
27 checks passed
@Pururun Pururun deleted the improve-native-debugging-experience-droid-1845 branch March 17, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants