Make Multihop feature chip appear if settings or current state say so

[acb-mv]

The Multihop feature chip has been modified to appear if the settings enable multihop, or if the current tunnel state is multihop (i.e., if this has been enabled due to DAITA)

---

This change is 

[linear]

IOS-1093 Multihop is not indicated as a feature indicator when being used to enable DAITA

[buggmagnet]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[mojganii]

Reviewable status: all files reviewed, 1 unresolved discussion

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/ChipView/ChipFeature.swift line 57 at r1 (raw file):

    let state: TunnelState
    var isEnabled: Bool {
        settings.tunnelMultihopState.isEnabled || state.isMultihop

Since either of these conditions (settings.tunnelMultihopState.isEnabled || settings.daita.isAutomaticRouting) implies multihop, there is no need for a computed variable for isMultihop or for State as a dependency injection here.

Code snippet:

   var isEnabled: Bool {
        settings.tunnelMultihopState.isEnabled || settings.daita.isAutomaticRouting
    }

[acb-mv]

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/ChipView/ChipFeature.swift line 57 at r1 (raw file):

Previously, mojganii wrote…

Since either of these conditions (settings.tunnelMultihopState.isEnabled || settings.daita.isAutomaticRouting) implies multihop, there is no need for a computed variable for isMultihop or for State as a dependency injection here.

Though if you have DAITA automatic routing enabled but select a relay that has DAITA, will that still enable multihop? I thought that in that case, your traffic will go through just that single relay, in which case a "Multihop" feature chip would be misleading.

[buggmagnet]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/ChipView/ChipFeature.swift line 57 at r1 (raw file):

if you have DAITA automatic routing enabled but select a relay that has DAITA, will that still enable multihop?

It will not.

[mojganii]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv and @buggmagnet)

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/ChipView/ChipFeature.swift line 57 at r1 (raw file):

Previously, buggmagnet wrote…

if you have DAITA automatic routing enabled but select a relay that has DAITA, will that still enable multihop?

It will not.

Since there is reliable information about the selected relays, which are filtered in the upper layer by relaySelectorWrapper, it is good enough to determine whether it is multi-hopping or not. Therefore, I retract my comment.