Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue in smart routing when selecting one to many relays #7820

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Mar 13, 2025

This PR fixes an issue where, if Daita with smart routing is enabled and the user selects a location without a Daita relay, the app goes into a blocked state instead of attempting to find a relay server from the remaining available relays.

You can reproduce this issue on main by following these steps:

  1. Set the provider to Tzulo in the Filter view and apply.
  2. Select Canada → The app goes into a blocked state, even though a Daita relay is available in USA.
  3. Select USA → The VPN successfully connects.

This change is Reviewable

@mojganii mojganii self-assigned this Mar 13, 2025
@mojganii mojganii added the iOS Issues related to iOS label Mar 13, 2025
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the fix-multihop-picker-issue-ios branch from 7567036 to 5064d24 Compare March 17, 2025 12:18
@buggmagnet buggmagnet merged commit fd7ea9b into main Mar 17, 2025
12 checks passed
@buggmagnet buggmagnet deleted the fix-multihop-picker-issue-ios branch March 17, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants