Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release meta.toml #7823

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Add release meta.toml #7823

merged 2 commits into from
Mar 17, 2025

Conversation

dlon
Copy link
Member

@dlon dlon commented Mar 14, 2025

meta was also updated to append /{version}/ to the base URL.


This change is Reviewable

@dlon dlon requested a review from Serock3 March 14, 2025 08:53
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion


mullvad-update/meta/src/artifacts.rs line 59 at r1 (raw file):

        .map(|base_url| {
            let url = base_url.strip_suffix("/").unwrap_or(base_url);
            format!("{url}/{version}/{}", filename)

Maybe a silly question, but can we expect/force third-party CDNs to supply the app with URLs that are grouped by their version?

Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


mullvad-update/meta/src/artifacts.rs line 59 at r1 (raw file):

Previously, Serock3 (Sebastian Holmin) wrote…

Maybe a silly question, but can we expect/force third-party CDNs to supply the app with URLs that are grouped by their version?

I assume so. It's the case for the one we currently have (which just mirrors our servers). If not, we'll have to complicate this.

@dlon dlon force-pushed the add-meta-toml-config branch from 1b08415 to 33fb7d6 Compare March 17, 2025 08:58
@dlon dlon merged commit 7df3893 into main Mar 17, 2025
52 of 53 checks passed
@dlon dlon deleted the add-meta-toml-config branch March 17, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants