Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in obfuscation info text #7834

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Mar 18, 2025


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Mar 18, 2025
@Pururun Pururun requested review from kl, Rawa and albin-mullvad March 18, 2025 07:41
Copy link

linear bot commented Mar 18, 2025

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 21 files at r1, all commit messages.
Reviewable status: 2 of 21 files reviewed, 1 unresolved discussion


android/lib/resource/src/main/res/values-sv/strings.xml line 253 at r1 (raw file):

    <string name="not_found">Hittades inte</string>
    <string name="number_of_providers">Leverantörer: %1$d</string>
    <string name="obfuscation_info">Obfuskering döljer WireGuard-trafik inne i ett annat protokoll. Det kan användas för att kringgå censur och andra filtertyper där en vanlig WireGuard-anslutning skulle blockeras.</string>

According to the diff this has not yet been addressed in the desktop app. Is that correct? Just double checking since I thought they already addressed it 🤔

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 21 files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/lib/resource/src/main/res/values-sv/strings.xml line 253 at r1 (raw file):

Previously, albin-mullvad wrote…

According to the diff this has not yet been addressed in the desktop app. Is that correct? Just double checking since I thought they already addressed it 🤔

Maybe we can fix it for the desktop app as well if they haven't already fixed it?

Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 21 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


android/lib/resource/src/main/res/values-sv/strings.xml line 253 at r1 (raw file):

Previously, albin-mullvad wrote…

Maybe we can fix it for the desktop app as well if they haven't already fixed it?

I think it is fixed, but not translated?

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 21 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/lib/resource/src/main/res/values-sv/strings.xml line 253 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I think it is fixed, but not translated?

Alright! 👍

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the wireguard-obfuscation-info-text-typo-droid-1851 branch from 2b59dbd to 8c58777 Compare March 18, 2025 11:48
@Pururun Pururun merged commit 49efba2 into main Mar 18, 2025
86 of 87 checks passed
@Pururun Pururun deleted the wireguard-obfuscation-info-text-typo-droid-1851 branch March 18, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants