Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native module being unpacked to temp dir #7845

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Fix native module being unpacked to temp dir #7845

merged 2 commits into from
Mar 20, 2025

Conversation

dlon
Copy link
Member

@dlon dlon commented Mar 19, 2025 •
edited
Loading

Fix DES-1780
Fix #7735

This change is Reviewable

@linear Linear
Copy link

linear bot commented Mar 19, 2025

DES-1780 Investigate Javascript error in issue #7731 from GitHub

@dlon dlon requested a review from Serock3 March 19, 2025 14:40
Serock3
Serock3 previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

MarkusPettersson98
MarkusPettersson98 requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this bug fix to the changelog IMHO 😊

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

MarkusPettersson98
MarkusPettersson98 reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fix node native module being unpacked to a temporary folder" or something like that

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the fix-node-mod-from-tmp branch from 9089b8a to 9ec5e66 Compare March 19, 2025 17:03
dlon
dlon commented Mar 19, 2025
View reviewed changes
Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this definitely belongs in the changelog. Fixed!

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

MarkusPettersson98
MarkusPettersson98 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the fix-node-mod-from-tmp branch from 9ec5e66 to c04409e Compare March 20, 2025 11:08
@dlon dlon merged commit ca47fc8 into main Mar 20, 2025
67 of 69 checks passed
@dlon dlon deleted the fix-node-mod-from-tmp branch March 20, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusPettersson98 MarkusPettersson98 MarkusPettersson98 approved these changes

@Serock3 Serock3 Serock3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript Error: TMP.NODE was prevented from running
3 participants
@dlon @Serock3 @MarkusPettersson98