Add Dot component #7848
Open
Add Dot component #7848
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-jarvelov
requested changes
Mar 20, 2025
| error: Colors.red, | ||
| }; | ||
|
|
||
| export const Dot = ({ variant = 'success', size = 'medium', ...props }: DotProps) => { |
There was a problem hiding this comment.
question: Do we really want variant to be optional and have success as the default value?
This might be confusing if we have logic which feed this component props, but for some reason omits the variant. If that happens we will accidentally render the success variant, when this might be because of an unhandled situation in the logic which feeds this component props. In this situation we will convey a positive indication to the user, when the opposite might be true.
suggestion: Make the variant required and remove the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is