Implement getrelays using mullvad api #7852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
commented
Mar 20, 2025
There was a problem hiding this comment.
To test, replace:
REST.APIProxy(configuration: configuration)
with:
MullvadAPIProxy(
transportProvider: configuration.apiTransportProvider,
dispatchQueue: DispatchQueue(label: "MullvadAPIProxy.dispatchQueue"),
responseDecoder: Coding.makeJSONDecoder()
)
in ProxyFactory.createAPIProxy().
Reviewable status: 0 of 18 files reviewed, all discussions resolved
rablador
force-pushed
the
implement-getrelays-using-mullvad-api-ios-1133
branch
6 times, most recently
from
683ae84 to
6d4e6c7
Compare
rablador
force-pushed
the
implement-getrelays-using-mullvad-api-ios-1133
branch
from
6d4e6c7 to
0cc6197
Compare
rablador
force-pushed
the
implement-getrelays-using-mullvad-api-ios-1133
branch
from
0cc6197 to
7b5d435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this needs to be done
getRelayscall should use the mullvad-api client, without replacing existing implementation.What needs to be done
The API proxy should be implemented using mullvad-api, allowing us to move to the new implementation without removing the old code. For fetching the relay list, the swift side needs to obtain an etag and then also pass the etag to rust again, so that the etag can be used when requesting a new relay list.
Duplicate methods in the APIQuerying interface should also be removed.
Acceptance criteria
There is an APIProxy implementation that uses mullvad-api.
This change is