Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to go to VPN settings from snackbar #7855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kl
Copy link
Contributor

@kl kl commented Mar 20, 2025


This change is Reviewable

@kl kl added the Android Issues related to Android label Mar 20, 2025
Copy link

linear bot commented Mar 20, 2025

@kl kl force-pushed the add-action-to-vpn-permission-snackbar-droid-1866 branch from 13ef5f5 to 114123f Compare March 20, 2025 15:49
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt line 220 at r1 (raw file):

                }
            is ConnectViewModel.UiSideEffect.ConnectError ->
                when (sideEffect) {

Unnecessary when statement it checks the same as the outer one, it should be possible to just flatten it and have Generic and PermissionDenied at top level.

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants