Do not show account number when copying to clipboard

[kl]

---

This change is 

[linear]

DROID-1875 Do not show account number when copying to clipboard

[Pururun]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/util/Clipboard.kt line 40 at r1 (raw file):

                    description.extras =
                        PersistableBundle().apply {
                            putBoolean("android.content.extra.IS_SENSITIVE", isSensitive)

Should be a constant

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/WelcomeScreen.kt line 291 at r1 (raw file):

    val copiedAccountNumberMessage = stringResource(id = R.string.copied_mullvad_account_number)
    val copyToClipboard =
        createCopyToClipboardHandle(snackbarHostState = snackbarHostState, isSensitive = true)

Not super important, but do we really need it in the WelcomeScreen? We already show the account number in plain text anyway?

[kl]

Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @albin-mullvad, @Pururun, and @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/WelcomeScreen.kt line 291 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Not super important, but do we really need it in the WelcomeScreen? We already show the account number in plain text anyway?

I don't have a strong preference either way. @Rawa @albin-mullvad opinions here?

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/util/Clipboard.kt line 40 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Should be a constant

Done.