Scroll to first checked custom location on open

[kl]

---

This change is 

[linear]

DROID-1609 Custom list location should scroll to the first selected location item

[Rawa]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 183 at r1 (raw file):

            }

            lazyListState.ScrollToFirstCheckedItem(state)

We hide away the Launched effect a bit here I feel like. It would be nice to have it one the top level if possible.

[Pururun]

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 247 at r1 (raw file):

        LaunchedEffect(Unit) {
            if (firstChecked != -1) {
                scrollToItem(firstChecked)

In select location we also have the animateScrollAndCentralizeItem function which we could use here also if we make it public and move it somewhere.

[Rawa]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @kl and @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 247 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

In select location we also have the animateScrollAndCentralizeItem function which we could use here also if we make it public and move it somewhere.

Does this one animate? Or just scroll to it? Not sure what we want though 🙃

[Pururun]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @kl and @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 247 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Does this one animate? Or just scroll to it? Not sure what we want though 🙃

IIRC animateScrollAndCentralizeItem is so that the item is centered and not at the top. Why we need both is a bit of mystery to me as well,

[Pururun]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @kl and @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 247 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

IIRC animateScrollAndCentralizeItem is so that the item is centered and not at the top. Why we need both is a bit of mystery to me as well,

Just checked and without scrollToItem you get this weird flickering and without animateScrollAndCentralizeItem it will just show the scrolled to item at the top of the list so I think both are required.

[kl]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Pururun and @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 183 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

We hide away the Launched effect a bit here I feel like. It would be nice to have it one the top level if possible.

Done.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt line 247 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Just checked and without scrollToItem you get this weird flickering and without animateScrollAndCentralizeItem it will just show the scrolled to item at the top of the list so I think both are required.

Done.

[Pururun]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/extensions/LazyListExtensions.kt line 45 at r3 (raw file):

    }

suspend fun LazyListState.animateScrollAndCentralizeItem(index: Int) {

Nice

[Rawa]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)