Implement changes to suggestedUpgrade in Electron #7881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-jarvelov
force-pushed
the
handle-changes-to-suggestedupgrade-format-des-1932
branch
2 times, most recently
from
98054e1 to
103604f
Compare
tobias-jarvelov
changed the title
tobias-jarvelov
force-pushed
the
handle-changes-to-suggestedupgrade-format-des-1932
branch
2 times, most recently
from
9d17706 to
b77ff14
Compare
tobias-jarvelov
changed the title
dlon
force-pushed
the
in-app-upgrades-on-windows-and-macos
branch
from
9ac60e2 to
268a41c
Compare
olmoh
approved these changes
Mar 25, 2025
desktop/packages/mullvad-vpn/src/shared/notifications/update-available.ts
Outdated
Show resolved
Hide resolved
It is never used and therefore does not need it.
To reflect changes in management interface where suggestedUpgrade has changed from a string to a message with its own fields.
tobias-jarvelov
force-pushed
the
handle-changes-to-suggestedupgrade-format-des-1932
branch
from
b77ff14 to
b1d279e
Compare
tobias-jarvelov
force-pushed
the
handle-changes-to-suggestedupgrade-format-des-1932
branch
from
b1d279e to
1ba0f9e
Compare
olmoh
approved these changes
Mar 25, 2025
tobias-jarvelov
merged commit 114b384
into
in-app-upgrades-on-windows-and-macos
9 checks passed
tobias-jarvelov
deleted the
handle-changes-to-suggestedupgrade-format-des-1932
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
AppVersionInfo.suggestedUpgradeproperty is updated, due to the changes in DES-1811 we need to make some changes in the code to handle the new format.This change is