Skip to content

Commit

Permalink
fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
popenta committed Feb 21, 2024
1 parent 1206019 commit a5240ac
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions src/transaction.local.net.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,23 +142,23 @@ describe("test transaction", function () {
it("should create transaction using the NextTokenTransferFactory", async function () {
this.timeout(70000);

let provider = createLocalnetProvider();
let watcher = new TransactionWatcher({
const provider = createLocalnetProvider();
const watcher = new TransactionWatcher({
getTransaction: async (hash: string) => {
return await provider.getTransaction(hash, true);
},
});

let network = await provider.getNetworkConfig();
const network = await provider.getNetworkConfig();

const config = new TransactionsFactoryConfig(network.ChainID);
const factory = new NextTransferTransactionsFactory(config, new TokenComputer());

await alice.sync(provider);
await bob.sync(provider);
let initialBalanceOfBob = new BigNumber(bob.account.balance.toString());
const initialBalanceOfBob = new BigNumber(bob.account.balance.toString());

let transaction = factory.createTransactionForNativeTokenTransfer({
const transaction = factory.createTransactionForNativeTokenTransfer({
sender: alice.address,
receiver: bob.address,
nativeAmount: 42000000000000000000n,
Expand All @@ -174,7 +174,7 @@ describe("test transaction", function () {
await watcher.awaitCompleted(txHash);

await bob.sync(provider);
let newBalanceOfBob = new BigNumber(bob.account.balance.toString());
const newBalanceOfBob = new BigNumber(bob.account.balance.toString());

assert.deepEqual(TokenTransfer.egldFromAmount(42).valueOf(), newBalanceOfBob.minus(initialBalanceOfBob));
});
Expand Down
2 changes: 1 addition & 1 deletion src/transactionsFactories/transferTransactionsFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ interface TokenComputer {

/**
* Use this class to create transactions for native token transfers (EGLD) or custom tokens transfers (ESDT/NTF/MetaESDT).
* This name is only temporary, the class will be renamed to `TransferTransactionsFactory`.
*/
// this name is only temporary; the class will be renamed to `TransferTransactionsFactory`
export class NextTransferTransactionsFactory {
private readonly config: IConfig;
private readonly dataArgsBuilder: TokenTransfersDataBuilder;
Expand Down

0 comments on commit a5240ac

Please sign in to comment.