Extended localnet tests to use the transaction factories, as well #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiprianDraghici
previously approved these changes
Mar 8, 2024
CiprianDraghici
previously approved these changes
Mar 25, 2024
andreibancioiu
previously approved these changes
Apr 5, 2024
src/testutils/contractController.ts
Outdated
| @@ -55,4 +57,14 @@ export class ContractController { | |||
| Logger.debug(`ContractController.query [end]: function = ${interaction.getFunction()}, return code = ${bundle.returnCode}`); | |||
| return bundle; | |||
| } | |||
|
|
|||
| private getTransactionHash(transaction: Transaction | TransactionNext): string { | |||
| if ("toSendable" in transaction){ | |||
There was a problem hiding this comment.
Could have checked by getHash, but fine this way, as well.
src/testutils/contractController.ts
Outdated
| @@ -55,4 +58,10 @@ export class ContractController { | |||
| Logger.debug(`ContractController.query [end]: function = ${interaction.getFunction()}, return code = ${bundle.returnCode}`); | |||
| return bundle; | |||
| } | |||
|
|
|||
| private getTransactionHash(transaction: Transaction): string { | |||
There was a problem hiding this comment.
Generally speaking, hash should also have been returned by await this.provider.sendTransaction(transaction);.
src/transaction.local.net.spec.ts
Outdated
| }, | ||
| }); | ||
| { timeoutMilliseconds: 100000 }, |
There was a problem hiding this comment.
Could have added a utility test function such as createTransactionWatcher.
andreibancioiu
changed the title
andreibancioiu
approved these changes
Apr 5, 2024
CiprianDraghici
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated the tests that run on
localnetto use the transaction factories. The old tests will be removed in the future, when the functionality will be deleted.