From 86be1cd5cb0d8a9856ff7354d98eccdb53f6d023 Mon Sep 17 00:00:00 2001 From: Ahmad ATWI Date: Wed, 21 Dec 2022 16:20:47 +0100 Subject: [PATCH] [#200] Make the GitLogItems.add public --- src/vcs/git_impl.go | 3 ++- src/vcs/git_log_item.go | 3 ++- src/vcs/git_log_item_test.go | 4 ++-- src/vcs/git_test_fake.go | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/vcs/git_impl.go b/src/vcs/git_impl.go index 12863a48..f8accc82 100644 --- a/src/vcs/git_impl.go +++ b/src/vcs/git_impl.go @@ -59,6 +59,7 @@ func New(dir string) (GitInterface, error) { return newGitImpl(plainOpen, dir) } +// newGitImpl initializes a gitImpl instance func newGitImpl(initRepo func(string) (*git.Repository, billy.Filesystem, error), dir string) (*gitImpl, error) { var g = gitImpl{ baseDir: dir, @@ -332,7 +333,7 @@ func (g *gitImpl) Log(msgFilter func(msg string) bool) (logs GitLogItems, err er } _ = cIter.ForEach(func(c *object.Commit) error { if msgFilter == nil || msgFilter(c.Message) { - logs.add(NewGitLogItem(c.Hash.String(), c.Committer.When.UTC(), c.Message)) + logs.Add(NewGitLogItem(c.Hash.String(), c.Committer.When.UTC(), c.Message)) } return nil }) diff --git a/src/vcs/git_log_item.go b/src/vcs/git_log_item.go index f6db140b..7ed4f14f 100644 --- a/src/vcs/git_log_item.go +++ b/src/vcs/git_log_item.go @@ -50,7 +50,8 @@ func (items *GitLogItems) sortByDate() { }) } -func (items *GitLogItems) add(d GitLogItem) { +// Add adds a GitLogItem to the GitLogItems collection +func (items *GitLogItems) Add(d GitLogItem) { *items = append(*items, d) } diff --git a/src/vcs/git_log_item_test.go b/src/vcs/git_log_item_test.go index c5424c8a..1e07e7a4 100644 --- a/src/vcs/git_log_item_test.go +++ b/src/vcs/git_log_item_test.go @@ -31,7 +31,7 @@ import ( func Test_add_regular_git_log_item(t *testing.T) { var items GitLogItems item := NewGitLogItem("xxx", time.Now(), "some message") - items.add(item) + items.Add(item) assert.Len(t, items, 1) assert.Contains(t, items, item) } @@ -39,7 +39,7 @@ func Test_add_regular_git_log_item(t *testing.T) { func Test_add_empty_git_log_item(t *testing.T) { var items GitLogItems item := NewGitLogItem("", time.Time{}, "") - items.add(item) + items.Add(item) assert.Len(t, items, 1) } diff --git a/src/vcs/git_test_fake.go b/src/vcs/git_test_fake.go index 02c77f24..014c5730 100644 --- a/src/vcs/git_test_fake.go +++ b/src/vcs/git_test_fake.go @@ -147,7 +147,7 @@ func (g *GitFake) Log(msgFilter func(msg string) bool) (logs GitLogItems, err er for _, log := range g.settings.Logs { if msgFilter(log.Message) { - logs.add(log) + logs.Add(log) } } return