Skip to content

Commit e166b45

Browse files
committed
[#200] Refactor supported VCS test case in vcs.factory package
1 parent d279937 commit e166b45

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

src/vcs/factory/vcs_factory_test.go

+9-10
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@ import (
2828
"testing"
2929
)
3030

31+
func Test_supported_vcs(t *testing.T) {
32+
for _, name := range []string{"git", "p4"} {
33+
t.Run(name, func(t *testing.T) {
34+
_, err := InitVCS(name, "")
35+
assert.NotEqual(t, reflect.TypeOf(&UnsupportedVCSError{}), reflect.TypeOf(err))
36+
})
37+
}
38+
}
39+
3140
func Test_vcs_factory_returns_an_error_when_vcs_is_not_supported(t *testing.T) {
3241
v, err := InitVCS("unknown-vcs", "")
3342
assert.IsType(t, &UnsupportedVCSError{}, err)
@@ -38,13 +47,3 @@ func Test_unsupported_vcs_message_format(t *testing.T) {
3847
err := UnsupportedVCSError{"some-vcs"}
3948
assert.Equal(t, "VCS not supported: \"some-vcs\"", err.Error())
4049
}
41-
42-
func Test_vcs_factory_supports_git(t *testing.T) {
43-
_, err := InitVCS("git", "")
44-
assert.NotEqual(t, reflect.TypeOf(&UnsupportedVCSError{}), reflect.TypeOf(err))
45-
}
46-
47-
func Test_vcs_factory_supports_p4(t *testing.T) {
48-
_, err := InitVCS("p4", "")
49-
assert.NotEqual(t, reflect.TypeOf(&UnsupportedVCSError{}), reflect.TypeOf(err))
50-
}

0 commit comments

Comments
 (0)