Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Display toolchain commands trace in real time #390

Closed
1 task done
mengdaming opened this issue Jul 25, 2023 · 0 comments · Fixed by #708
Closed
1 task done

[Feature]: Display toolchain commands trace in real time #390

mengdaming opened this issue Jul 25, 2023 · 0 comments · Fixed by #708
Assignees
Labels
enhancement New feature or request M Medium

Comments

@mengdaming
Copy link
Contributor

Contact Details

damien.menanteau@gmail.com

Feature Request

Currently, when running an external command (such as gradle, maven, git, etc), TCR waits for the command to terminate before reporting its output into the terminal.

As long as these commands run fast this is almost transparent and therefore is not an issue. This becomes more problematic when external commands take a longer time to complete (git operations over a slow network, slow build or test commands, ...) as this gives the user the impression that TCR is hanging, while it's actually only waiting for external commands to end.

Having the ability to report subcommands trace in real time would solve this problem.

Feature Description

Rework the external command calls so that stdout and stderr traces are traced back into the terminal regularly before the command ends (line by line trace should be enough).

We should be careful that these changes do not alter the current TCR workflow.

Alternatives

N/A

Additional Context

Here's a blog post on how to capture an external command output and show progress at the same time:

https://blog.kowalczyk.info/article/wOYk/advanced-command-execution-in-go-with-osexec.html

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mengdaming mengdaming added enhancement New feature or request M Medium labels Jul 25, 2023
@mengdaming mengdaming self-assigned this Jul 3, 2024
@mengdaming mengdaming moved this from To do to In progress in TCR Enhancements & Bugs Follow Up Jul 3, 2024
mengdaming added a commit that referenced this issue Jul 3, 2024
mengdaming added a commit that referenced this issue Jul 5, 2024
- Extract toolchain command execution functions into a separate file (command_runner.go)
- Report command traces line by line, instead of dumping all traces after command completion
mengdaming added a commit that referenced this issue Jul 5, 2024
…d is not found

- Also improve smoke tests to verify behaviour for both a failing command and a command not found
@mengdaming mengdaming linked a pull request Jul 6, 2024 that will close this issue
6 tasks
mengdaming added a commit that referenced this issue Jul 8, 2024
- Extract toolchain command execution functions into a separate file (command_runner.go)
- Report command traces line by line, instead of dumping all traces after command completion
mengdaming added a commit that referenced this issue Jul 8, 2024
…d is not found

- Also improve smoke tests to verify behaviour for both a failing command and a command not found
@github-project-automation github-project-automation bot moved this from In progress to Done in TCR Enhancements & Bugs Follow Up Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request M Medium
Development

Successfully merging a pull request may close this issue.

1 participant