Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

200 perforce vcs #232

Merged
merged 45 commits into from
Feb 1, 2023
Merged

200 perforce vcs #232

merged 45 commits into from
Feb 1, 2023

Conversation

mengdaming
Copy link
Contributor

Description:

  • Add Perforce implementation (experimental, cf. README.md for current limitations)
  • Refactor terminal's menus in a more structured way

Fixes #200 #196

Type of change

Please tick the appropriate option using [x]

  • Bug fix
  • New feature
  • Enhancement

Checklist:

Please tick the appropriate options using [x]

  • My PR includes tests that cover my code changes.
  • Lint and formatter run with no errors
  • All new and old tests are passing

mengdaming and others added 30 commits February 1, 2023 11:59
@mengdaming
[#200] Add vcs/p4 package and p4 command wrapper
e0e5acf
@mengdaming
[#200] Add p4 implementation skeleton
48e7ed8
@mengdaming
[#200] Add --vcs command line option allowing to chose VCS at startup
5eba709 
- Possible options for vcs: git (default) or p4
- Add minimal checker functions in order to ckeck either git or p4 setup
- Add tcr-local-p4 to be able to run local build with p4
- Start implementing p4 wrapper (pull, push, stub  auto-push and branch related functions)
@mengdaming
[#200] Add --vcs command line option allowing to chose VCS at startup
97878ce 
- Possible options for vcs: git (default) or p4
- Add minimal checker functions in order to ckeck either git or p4 setup
- Add tcr-local-p4 to be able to run local build with p4
- Start implementing p4 wrapper (pull, push, stub  auto-push and branch related functions)
@mengdaming
[#200] Add possibility to run or trace piped commands
4f2597c 
- required to run automated p4 changelist creation
@mengdaming
[#200] Skip tests requiring p4 on GitHub actions
59dec4f
@mengdaming
[#200] Make vcs/cmd test cases OS independent
c2e7a0c 
- Tests were failing in Windows CI due to extra CR character
@mengdaming
[#200] Add vcs/p4 implementation for Add(), Commit(), Push()
a2e9236
@mengdaming
[#200] Fix vcs/cmd test case on Unix OS's
3ec6c5e
@mengdaming
[#200] Rename vcs/cmd package to vcs/shell
0a3ba4a
@mengdaming
[#200] Implement p4 diff
6805089
@mengdaming
Update dependencies
6fd2195
@mengdaming
[#200] Add vcs/p4 tests for push, add and commit
761d535
@mengdaming
Remove dangling test on git remote access
fed993c
@mengdaming
[#200] Stub out vcs/p4 command calls
9b2b10d 
- In order to be able to run p4 tests withous having p4 installed and configured
@mengdaming
[#200] Extend sonar.test.inclusion pattern to all kinds of test doubles
f0896b2
@mengdaming
[#200] Minor improvements on vcs/shell/CommandStub
0c767bb
@mengdaming
[#200] Add a function to retrieve p4 clientName
265c34f
@mengdaming
[#200] Add a function to convert TCR basedir to P4 path
71962d6
@mengdaming
[#200] Fix the failing tests on unix
0ad9a79
@mengdaming
[#200] Add -c client_name option to the p4 command line
cf33a3f
@mengdaming
[#200] Make the p4 sync always use the base_dir p4 path
219b06b
@mengdaming
[#200] Minor improvements on vcs/p4 implementation
9ae94ce
@mengdaming
[#200] Simplify vcs/p4 global parameters tests
e2f9e30
@mengdaming
[#200] Sync vcs/git tests approach with vcs/p4 tests
550216e 
- now using stubbed git command calls instead of real calls
@mengdaming
[#200] Add a few edge test case in vcs/p4 package
0bee608
@mengdaming
[#200] Add test case for checking git remote access (stubbing git com…
799bfd3 
…mand call)
@mengdaming
[#200] Add tests on retrieving p4 root directory
6581b08
@mengdaming
[#200] Fix retrieving p4 info value
65483cd
@mengdaming
[#200] Add methods Name() and SessionInfo() to vcs interface
0706288 
- evolving towards a more generic VCS interface
mengdaming and others added 15 commits February 1, 2023 11:59
@mengdaming
[#200] add vcs.factory package
80f6fec
@mengdaming
[#200] Refactor supported VCS test case in vcs.factory package
4d56bd9
@mengdaming
[#196] Add menu and menu_option types and use them in terminal main menu
83a22b2
@mengdaming
[#196] Add possibility to enable/disable a menu_option
a2551e5
@mengdaming
[#196] Refactor the terminal's main menu function
1e6762f
@mengdaming
[#196] Replace menuOption's enabled attribute with a menuEnabler func…
8626cea 
…tion
@mengdaming
[#196] Refactor the terminal's role menu function using new menu stru…
7326d5b 
…cture
@mengdaming
[#196] Extract menu enablers and actions into separate methods
8676c00
@mengdaming
[#196] Add test cases on cli/menu.matchAndRun()
2561c4f
@mengdaming
[#196] Simplify cli/terminal test cases on menu actions
b51ff92
@mengdaming
[#196] Improve display of menu arrows and horizontal lines
bdce072
@mengdaming
[#200] Customize main menu depending on used VCS
ad03ecf 
- "P - Auto push toggle" is available only with git
- "L - Pull" is available only with git
- "S - Push" is available only with git
- "Y - Sync"  is available only with p4
@mengdaming
[#200] Refactor display of VCS info to show meaningful info only
81e3637
@mengdaming
[#200] Move git auto-push checking under git environment checker
02679eb
@philou @mengdaming
[#200] Update doc with Perforce info
f52b8fb 
To support Perforce
- update Readme.md with a section on Perforce
- update Readme.md to remove git-specific wording
- update build.md to explain how to test TCR with Perforce locally
@mengdaming mengdaming linked an issue Feb 1, 2023 that may be closed by this pull request
[Feature]: Support Perforce as a VCS #200
Closed
77 tasks
@mengdaming mengdaming self-assigned this Feb 1, 2023
@mengdaming mengdaming linked an issue Feb 1, 2023 that may be closed by this pull request
Add a structured way for handling menu shortcuts #196
Closed
29 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

93.6% 93.6% Coverage
0.0% 0.0% Duplication

@mengdaming mengdaming merged commit 02243ed into main Feb 1, 2023
@mengdaming mengdaming deleted the 200-perforce-vcs branch February 1, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatwi aatwi Awaiting requested review from aatwi aatwi is a code owner

@philou philou Awaiting requested review from philou philou is a code owner

Assignees

@mengdaming mengdaming

Labels
None yet
Projects
TCR Enhancements & Bugs Follow Up
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support Perforce as a VCS Add a structured way for handling menu shortcuts
2 participants
@mengdaming @philou