Feature/390 real time trace #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract toolchain command execution functions into a separate file (command_runner.go) - Report command traces line by line, instead of dumping all traces after command completion
…d is not found - Also improve smoke tests to verify behaviour for both a failing command and a command not found
1 task
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows to display toolchain commands execution trace in "real time" (e.g. line per line) instead of dumping the whole trace after commands are completed. This is expected to improve UX, especially to remove the false impression that TCR is hanging, while it's actually waiting for a slow command to terminate.
Fixes #390
Type of change
Please tick the appropriate option using [x]
Checklist:
Please tick the appropriate options using [x]