Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to abort a toolchain build or test operation #719

Merged
merged 10 commits into from
Jul 17, 2024

Conversation

mengdaming
Copy link
Contributor

Description:

With this change, TCR now provides a way to interrupt a toolchain build or test command without waiting for it to complete.

  • From the CLI, this can be achieved through the a / A shortcut
  • From the webapp, this can be achieved through a button Abort Current Command located at the bottom of the TCR Console page

Impact on TCR behavior:

  • Aborting a build command execution implies that the build is considered as failed, thus tests are not executed and no file gets reverted
  • Aborting a test command execution implies that the tests are considered as failed, thus leading to reverting latest changes in production code

Fixes #694

Type of change

Please tick the appropriate option using [x]

  • Bug fix
  • New feature

Checklist:

Please tick the appropriate options using [x]

  • My PR includes tests that cover my code changes.
  • Lint and formatter run with no errors
  • All new and old tests are passing

@mengdaming mengdaming requested review from aatwi and philou as code owners July 15, 2024 08:26
@mengdaming mengdaming linked an issue Jul 15, 2024 that may be closed by this pull request
1 task
Copy link

Copy link
Member

@aatwi aatwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the PR looks good! I just noticed that some TS files do not have the copyright section

@mengdaming
Copy link
Contributor Author

indeed. This is probably the case for most if not all of them.

I propose that we merge this PR, then I'll run a global update adding the copyright header in all TS files in one shot. WDYT?

@mengdaming mengdaming merged commit a766530 into main Jul 17, 2024
15 checks passed
@mengdaming mengdaming deleted the bugfix/694-infinite-loops branch July 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TCR Freezing when python code gets into an infinite loop
2 participants