Fix unnecessary ValueError in PairPlot: Caused by unrelated duplicated columns not used in vars
#3840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple demo:
The Traceback:
The error happens inside self._find_numeric_cols(data), which is unnecessary when
vars
is provided. So I skip it and extend to some other similar scenarios:vars
: Gives a simple warning. It just generates unexpected figures but does not crash.vars
: raise ValueError in PairGrid Class, specify the related duplicants.vars
is not provided: raise ValueError in PairGrid Class, specify the all duplicants.These tests are all included in the test_axisgrid.py
Please let me know if any other modifications are needed.