Skip to content

feat enable mask log by maskLog for parameter locally and maskLogResultColumns for result globally #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

yanxutao89
Copy link
Contributor

No description provided.

@yanxutao89
Copy link
Contributor Author

yanxutao89 commented Jun 12, 2025

Can this PR continue? @harawata @hazendaz

@harawata
Copy link
Member

Hello @yanxutao89 ,

Thank you for the PR!

Personally, I don't see this feature particularly useful because...

  • On production environment, you would not enable DEBUG or TRACE level logging.
  • On development environment, there is no point in masking password etc..

Still, if other devs like the idea and there is a clean solution which does not affect performance, I would not object.

With regard to this particular PR, the change to the TypeHandler interface is not acceptable in my view (as I only took a quick look, there could be more).

Related to #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants