Skip to content

Commit b00fd34

Browse files
Added logger usage in the reasonner and the unit repo web service classes
1 parent 619c9fd commit b00fd34

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

src/main/java/com/mycsense/carbondb/Reasoner.java

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121

2222
import org.mindswap.pellet.jena.PelletReasonerFactory;
2323
import org.mindswap.pellet.jena.PelletInfGraph;
24+
import org.slf4j.Logger;
25+
import org.slf4j.LoggerFactory;
2426

2527
public class Reasoner {
2628

@@ -41,6 +43,8 @@ public class Reasoner {
4143
public ReasonnerReport report = new ReasonnerReport();
4244
protected UnitsRepo unitsRepo;
4345

46+
private final Logger log = LoggerFactory.getLogger(Reasoner.class);
47+
4448
public Reasoner (Model model, UnitsRepo unitsRepo) {
4549
this.model = model;
4650
this.unitsRepo = unitsRepo;
@@ -53,7 +57,7 @@ public void run () {
5357
convert source relations -> sourceRelations convert
5458
calculate ecological flows -> calculate ecological flows
5559
*/
56-
System.out.println("begin reasonning");
60+
log.info("Begin reasonning");
5761
infModel = ModelFactory.createInfModel( jenaReasoner, model );
5862
((PelletInfGraph) infModel.getGraph()).classify();
5963
((PelletInfGraph) infModel.getGraph()).realize();
@@ -64,7 +68,7 @@ public void run () {
6468
RepoFactory.setReasonnerReport(report);
6569
relationRepo = RepoFactory.getRelationRepo();
6670
singleElementRepo = RepoFactory.getSingleElementRepo();
67-
System.out.println("loading and translating sourceRelations");
71+
log.info("Loading and translating sourceRelations");
6872
for (Resource sourceRelationResource: relationRepo.getSourceRelationsResources()) {
6973
try {
7074
SourceRelation sourceRelation = relationRepo.getSourceRelation(sourceRelationResource);
@@ -75,14 +79,14 @@ public void run () {
7579
}
7680
}
7781

78-
System.out.println("getting single processes");
82+
log.info("Getting single processes");
7983
processes = singleElementRepo.getSingleProcesses();
80-
System.out.println("getting elementary flow types");
84+
log.info("getting elementary flow types");
8185
elementaryFlowTypes = singleElementRepo.getElementaryFlowTypes();
82-
System.out.println("getting impact types");
86+
log.info("Getting impact types");
8387
impactTypes = singleElementRepo.getImpactTypes();
8488

85-
System.out.println("creating ecological matrices");
89+
log.info("Creating ecological matrices");
8690
createEcologicalMatrix();
8791
createFlowToImpactsMatrix();
8892

@@ -95,20 +99,20 @@ public void run () {
9599
//createMatrix();
96100
//calculateCumulatedEcologicalFlows();
97101

98-
System.out.println("creating matrix");
102+
log.info("Creating matrix");
99103
createMatrices();
100-
System.out.println("calculating cumulative flows");
104+
log.info("Calculating cumulative flows");
101105
iterativeCalculationWithoutUncertainties();
102106
cumulativeEcologicalMatrix = transitiveDependencyMatrix.multiply(ecologicalMatrix);
103-
System.out.println("calculating impacts");
107+
log.info("Calculating impacts");
104108
impactMatrix = cumulativeEcologicalMatrix.multiply(flowToImpactsMatrix.transpose());
105109

106-
System.out.println("creating calculated flows");
110+
log.info("Creating calculated flows");
107111
createCumulatedEcologicalFlows();
108-
System.out.println("creating impacts");
112+
log.info("Creating impacts");
109113
createImpacts();
110114

111-
System.out.println("reasoning finished");
115+
log.info("Reasoning finished");
112116
}
113117

114118
public void createMatrix() {

src/main/java/com/mycsense/carbondb/architecture/UnitsRepoWebService.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
import com.mycsense.carbondb.domain.Unit;
1212
import org.json.JSONObject;
1313
import org.json.JSONArray;
14+
import org.slf4j.Logger;
15+
import org.slf4j.LoggerFactory;
1416

1517
public class UnitsRepoWebService implements UnitsRepo, UnitsRepoCache {
1618
protected HashMap<String, Double> conversionFactorsCache = new HashMap<>();
@@ -22,10 +24,12 @@ public void setUnitsAPIURI(String unitsAPIURI) {
2224
this.unitsAPIURI = unitsAPIURI;
2325
}
2426

27+
private final Logger log = LoggerFactory.getLogger(UnitsRepoWebService.class);
28+
2529
public Double getConversionFactor(String unitID)
2630
{
2731
if (!conversionFactorsCache.containsKey(unitID)) {
28-
System.out.println("fetching conversion factor for " + unitID);
32+
log.debug("fetching conversion factor for " + unitID);
2933
String unitOfReference = findUnitOfReference(unitID);
3034
if (null == unitOfReference) {
3135
// unit not found (or error)
@@ -58,7 +62,7 @@ public boolean areCompatible(String unitID1, String unitID2)
5862
compatibleUnitsCache.put(unitID1, new HashMap<String, Boolean>());
5963
}
6064
if (!compatibleUnitsCache.get(unitID1).containsKey(unitID2)) {
61-
System.out.println("fetching compatibility between " + unitID1 + " & " + unitID2);
65+
log.debug("fetching compatibility between " + unitID1 + " & " + unitID2);
6266
Response response = buildBaseWebTarget()
6367
.path("compatible")
6468
.queryParam("units[0]", unitID1)
@@ -95,7 +99,7 @@ public String getUnitsMultiplication(Unit unit1, Unit unit2, int exponent)
9599
public String getUnitSymbol(String unitID)
96100
{
97101
if (!symbolsCache.containsKey(unitID)) {
98-
System.out.println("fetching symbol for " + unitID);
102+
log.debug("fetching symbol for " + unitID);
99103
Response response = buildBaseWebTarget()
100104
.path("unit")
101105
.path(unitID)

0 commit comments

Comments
 (0)