Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Toggle Switch UI Bug: Inconsistent Behavior on Body vs. Button Click #709

Closed
1 task done
Vedant9500 opened this issue Feb 8, 2025 · 2 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working solved This doesn't seem right

Comments

@Vedant9500
Copy link

Describe the bug

In the ML4W dotfile, toggle switches are not functioning correctly.

Clicking on the body of the switch should toggle its state, but the color does not change to blue when turned on.
Clicking directly on the button (circle) instead of the body results in the script getting turned off while the toggle appears to turn on.
This means the visual state of the toggle and the actual script state are desynchronized.

Possible Causes:

Event listener may not be correctly handling clicks on both the toggle body and the button separately.
The CSS logic controlling the toggle’s appearance might not be updating properly after state changes.

Steps to reproduce

  1. Open the settings app.
  2. Click on "show waybar" body (or any available toggle switch).
  3. When it's turned off, try clicking on the toggle button.

Expected behavior

Clicking anywhere on the toggle should properly update both its visual state (color) and the script state (on/off) in sync.

Screenshots

Image

Image

Image

Distribution

Arch Linux

If Other, specify

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Vedant9500 Vedant9500 added the bug Something isn't working label Feb 8, 2025
@Vedant9500 Vedant9500 changed the title [BUG] [BUG] Toggle Switch UI Bug: Inconsistent Behavior on Body vs. Button Click Feb 8, 2025
@mylinuxforwork
Copy link
Owner

Thank you. Will fix it.

@mylinuxforwork mylinuxforwork added the in work This issue is being worked on label Feb 8, 2025
@mylinuxforwork mylinuxforwork added solved This doesn't seem right and removed in work This issue is being worked on labels Feb 26, 2025
@mylinuxforwork
Copy link
Owner

Fixed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working solved This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants