Skip to content

Commit d6dcced

Browse files
committed
[Scorecards] Changed fractions to 'Out of' in question marking
After doing some testing and I noticed that the fractions might be confusing for some users. By using something more literal we might make it easier to analyse the information for the questions.
1 parent d2ec6b3 commit d6dcced

File tree

1 file changed

+29
-18
lines changed

1 file changed

+29
-18
lines changed

scoring/templates/scoring/council.html

+29-18
Original file line numberDiff line numberDiff line change
@@ -327,28 +327,39 @@ <h3 class="exclamation text-white">Visit us again on a bigger screen</h3>
327327
</td>
328328

329329
<td data-column="score" class="score border-bottom">
330-
<span>{{ answer.score|format_mark }}/{{ answer.max }}</span>
331-
<!-- TODO: Change bg-green-100 to bg-red-100 if variation is negative -->
332-
<!-- TODO: Change text-success to text-danger if variation is negative -->
333-
<!-- TODO: Change bg-green-100 to bg-gray-100 if there is no variation -->
334-
<!-- TODO: Change text-success to text-dark if there is no variation -->
335-
<!-- TODO: If there is no variation then display '-' -->
336-
<!-- TODO: If question didn't exist in previous years then let's add 'NA' with bg-gray-100 text-dark -->
337-
<!-- TODO Designer: Add tooltip to badge explaining this is a variation -->
338-
<button type="button" data-bs-toggle="tooltip" data-bs-placement="bottom" title="Variation with Action Scorecards 2023" class="badge small ms-2 mb-0 align-text-bottom bg-green-100 text-success border-0">+1</button>
330+
<div class="d-flex flex-row gap-3 justify-content-end align-items-center">
331+
<p class="mb-0">
332+
<span class="fs-5">{{ answer.score|format_mark }} <span class="fs-7">out of </span> {{ answer.max }}
333+
</span>
334+
</p>
335+
336+
<!-- TODO: Change bg-green-100 to bg-red-100 if variation is negative -->
337+
<!-- TODO: Change text-success to text-danger if variation is negative -->
338+
<!-- TODO: Change bg-green-100 to bg-gray-100 if there is no variation -->
339+
<!-- TODO: Change text-success to text-dark if there is no variation -->
340+
<!-- TODO: If there is no variation then display '-' -->
341+
<!-- TODO: If question didn't exist in previous years then let's add 'NA' with bg-gray-100 text-dark -->
342+
<!-- TODO Designer: Add tooltip to badge explaining this is a variation -->
343+
<button type="button" data-bs-toggle="tooltip" data-bs-placement="bottom" title="Variation with Action Scorecards 2023" class="badge small ms-2 mb-0 align-text-bottom bg-green-100 text-success border-0">+1</button>
344+
</div>
339345
</td>
340346

341347
{% for comparison in answer.comparisons %}
342348
<td data-column="score" class="d-none d-md-table-cell score border-bottom">
343-
<span>{{ comparison.score|format_mark }}/{{ comparison.max }}</span>
344-
<!-- TODO: Change bg-green-100 to bg-red-100 if variation is negative -->
345-
<!-- TODO: Change text-success to text-danger if variation is negative -->
346-
<!-- TODO: Change bg-green-100 to bg-gray-100 if there is no variation -->
347-
<!-- TODO: Change text-success to text-dark if there is no variation -->
348-
<!-- TODO: If there is no variation then display '-' -->
349-
<!-- TODO: If question didn't exist in previous years then let's add 'NA' with bg-gray-100 text-dark -->
350-
<!-- TODO Designer: Add tooltip to badge explaining this is a variation -->
351-
<button type="button" data-bs-toggle="tooltip" data-bs-placement="bottom" title="Variation with Action Scorecards 2023" class="badge small ms-2 mb-0 align-text-bottom bg-green-100 text-success border-0">+1</button>
349+
<div class="d-flex flex-row gap-3 justify-content-end align-items-center">
350+
<p class="mb-0">
351+
<span class="fs-5">{{ comparison.score|format_mark }} <span class="fs-7">out of </span> {{ comparison.max }}
352+
</span>
353+
</p>
354+
<!-- TODO: Change bg-green-100 to bg-red-100 if variation is negative -->
355+
<!-- TODO: Change text-success to text-danger if variation is negative -->
356+
<!-- TODO: Change bg-green-100 to bg-gray-100 if there is no variation -->
357+
<!-- TODO: Change text-success to text-dark if there is no variation -->
358+
<!-- TODO: If there is no variation then display '-' -->
359+
<!-- TODO: If question didn't exist in previous years then let's add 'NA' with bg-gray-100 text-dark -->
360+
<!-- TODO Designer: Add tooltip to badge explaining this is a variation -->
361+
<button type="button" data-bs-toggle="tooltip" data-bs-placement="bottom" title="Variation with Action Scorecards 2023" class="badge small ms-2 mb-0 align-text-bottom bg-green-100 text-success border-0">+1</button>
362+
</div>
352363
</td>
353364
{% endfor %}
354365

0 commit comments

Comments
 (0)