Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scorecards] Added year comparison question page #735

Draft
wants to merge 4 commits into
base: 2025-scorecards
Choose a base branch
from
Draft

[Scorecards] Added year comparison question page #735

wants to merge 4 commits into from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Mar 6, 2025 •
edited
Loading

  • Confirm what will do with questions that have change their maximum scores between 2023 and 2025. My guess is we should't show any difference. Instead let's display a message below the overview cards explaining why there is no comparison.

Desktop

Screen.Recording.2025-03-10.at.08.50.49.mov

Mobile

Screen.Recording.2025-03-10.at.09.16.52.mov

@lucascumsille lucascumsille force-pushed the year-comparison-question-table-v2 branch 2 times, most recently from f310ad9 to 56b8fc3 Compare March 6, 2025 07:34
@lucascumsille lucascumsille changed the base branch from master to 2025-scorecards March 6, 2025 07:34
@lucascumsille lucascumsille force-pushed the year-comparison-question-table-v2 branch 3 times, most recently from fa27431 to 2519ff8 Compare March 10, 2025 08:44
@lucascumsille
[Scorecards] Layout and minor fixes to question pages
a691c4f 
- Improved hierarchy for titles.
- Limit the width for h1 question title in hero section.
- Decreased font-size for question title in hero section.
- Fix indentation to 4 spaces
- Fixes tooltip for Question weight in hero section.
@lucascumsille lucascumsille force-pushed the year-comparison-question-table-v2 branch 4 times, most recently from f0ddff3 to 18af5b1 Compare March 10, 2025 09:08
@lucascumsille lucascumsille force-pushed the year-comparison-question-table-v2 branch from 18af5b1 to 097d45d Compare March 10, 2025 09:16
@lucascumsille
Copy link
Contributor Author

lucascumsille commented Mar 10, 2025 •
edited
Loading

@struan I think we are ready with the question page, but if you prefer we could wait for tomorrow, however this is the same version CEUK gave the approval last week.
I need to double check with them tomorrow how we will handle when a question has changed its maximum score from one year to another and also when is a new question. At the moment I have added two messages that should handle both scenarios, but I'll check with them tomorrow. I think in worst case scenario the copy will change.

@lucascumsille
Copy link
Contributor Author

@struan, in our call with CEUK today, they suggested there might be questions where they wouldn't want a comparison between years, and it won't be a matter of "New question". Some questions changed their criteria quite a bit, and they probably don't want those questions to be compared, so they were asking if there is a way to tackle cases like that.

Regarding the scenario where the "maximum score" changes between years, they haven't decided whether to use the grey message advising users about the score changes. I'll check with them again.

Besides the above, we can move ahead with this branch.

@zarino zarino mentioned this pull request Mar 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucascumsille