Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer page saving improvements #171

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Conversation

struan
Copy link
Member

@struan struan commented Jun 27, 2024

This provides feedback as the user goes by submitting forms with JS to indicate which fields are required/are invalid.

It also prevents the user clicking Save if there are invalid fields.

Fixes #135

@struan struan force-pushed the 135-answer-saving-improvements branch 2 times, most recently from a821754 to 487a039 Compare July 1, 2024 14:14
@struan struan marked this pull request as ready for review July 1, 2024 14:23
@struan struan requested a review from zarino July 1, 2024 14:23
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacking the data to test this out locally, but have left a few comments on the code. Feel free to adopt or ignore!

@struan struan requested a review from zarino July 2, 2024 12:59
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@struan struan force-pushed the 135-answer-saving-improvements branch from d3712f8 to 8692831 Compare July 15, 2024 09:41
@struan struan merged commit 8692831 into main Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to answer saving process
2 participants