Skip to content

Commit b7730fc

Browse files
committed
Fix up membership test via post
1 parent 1a6ba07 commit b7730fc

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/mysoc_validator/models/popolo.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -512,14 +512,17 @@ def membership_on_date(
512512
memberships = self.memberships()
513513
if memberships:
514514
for m in memberships:
515-
if m.organization_id == chamber:
515+
post = m.post()
516+
if post and post.organization_id == chamber:
516517
if m.start_date <= date <= m.end_date:
517518
return m
518519

519520
def latest_membership(self, chamber: Chamber) -> Optional[Membership]:
520-
chamber_memberships = [
521-
m for m in self.memberships() if m.organization_id == chamber
522-
]
521+
chamber_memberships: list[Membership] = []
522+
for m in self.memberships():
523+
post = m.post()
524+
if post and post.organization_id == chamber:
525+
chamber_memberships.append(m)
523526
if chamber_memberships:
524527
return max(chamber_memberships, key=lambda m: m.start_date)
525528

0 commit comments

Comments
 (0)