[Bristol] Add attribute fallback support.

Author: dracos

perllib/Open311/Endpoint/Integration/UK/Bristol/Alloy.pm

@@ -51,14 +51,18 @@ sub process_attributes {
     };
 
     my $attributes_names = $self->config->{request_to_resource_attribute_manual_mapping}->{$args->{service_code_alloy}};
+    my $attribute_fallback = $self->config->{request_attribute_defaults}{$code};
 
     for my $att (keys %$attributes_names) {
         next if $att eq 'JobType';
-        next unless length $args->{attributes}->{$att};
+        next unless length $args->{attributes}->{$att} || $attribute_fallback->{$att};
+
+        my $value = length $args->{attributes}->{$att} ? $args->{attributes}->{$att} : $attribute_fallback->{$att};
+        $value = $attributes_values->{$att}->[ $value ] if $attributes_values->{$att};
 
         my $myattrib = {
             attributeCode => $attributes_names->{$att},
-            value => $attributes_values->{$att} ?  $attributes_values->{$att}->[ $args->{attributes}->{$att} ] : $args->{attributes}->{$att},
+            value => $value,
         };
 
         if ($myattrib->{value} =~ /^[01]$/) {

t/open311/endpoint/bristol_alloy.t

@@ -279,7 +279,6 @@ for my $test (
     {
         title => "Dead cow report",
         extra_params => {
-            'attribute[SizeOfIssue]' => '1',
             'attribute[TypeOfAnimal]' => '1',
             'attribute[category]' => 'Dead animal',
             'service_code' => 'Dead_animal',

t/open311/endpoint/bristol_alloy.yml

@@ -68,6 +68,13 @@
       },
    },
 
+  "request_attribute_defaults": {
+    "Bin overflowing": { "SizeOfIssue": 1 },
+    "Bin damaged": { "SizeOfIssue": 1 },
+    "Dead animal": { "SizeOfIssue": 1 },
+    "Dog fouling": { "SizeOfIssue": 1 },
+  },
+
   "request_attribute_to_values": {
     "SizeOfIssue": ["5e1f1be1ca3150041c4141fb", "5e1f1bf0ca31500c541f82cb", "5e1f1bffca31500c541f82d8", "5e1f1c0aca31500f4ca4d4e5"],
     "PropertyType": ['5e1f3aa5ca31500b78e78b16', '5e1f3ad1ca31500b78e78c3f'],