[Bristol][Alloy] Change grep on category code to be an exact match

A grep of the category code should be an exact match
and not regexp to prevent conflict with regexp
characters - and better form as should be an
exact match anyway.

Author: MorayMySoc

perllib/Open311/Endpoint/Integration/UK/Bristol/Alloy.pm

@@ -33,7 +33,7 @@ sub process_attributes {
 
     my $attributes_values = $self->config->{'request_attribute_to_values'};
     my $code = $args->{service_code_alloy};
-    if (grep { $code =~ /$_/ } keys %{
+    if (grep { $code eq $_ } keys %{
             {
                 %{$self->config->{service_whitelist}->{'SC-Street Cleansing'} || {} },
                 %{$self->config->{service_whitelist}->{'Abandoned bikes/scooters'} || {} }

t/open311/endpoint/bristol_alloy.t

@@ -164,8 +164,19 @@ subtest "check service group and category aliases" => sub {
             'service_code' => 'Dog_fouling',
             'keywords' => '',
             'description' => 'Dog fouling'
-          }
-        ];
+          },
+          {
+            "type" => "realtime",
+            "metadata" => "true",
+            "service_name" => "Glass (broken or not)",
+            "groups" => [
+                "Street cleansing"
+            ],
+            "keywords" => "",
+            "service_code" => "Glass_(broken_or_not)",
+            "description" => "Glass (broken or not)"
+          },
+    ]
 };
 
 my %shared_params = (
@@ -319,6 +330,22 @@ for my $test (
         },
         expected_design => 'designs_bWCSCStreetCleansingDefect_5e21a98bca315003e0983035',
     },
+    {
+        title => "Glass (broken or not) report",
+        extra_params => {
+            'attribute[SizeOfIssue]' => '1',
+            'attribute[category]' => 'Glass (broken or not)',
+            'service_code' => 'Glass_(broken_or_not)',
+        },
+        expected => {
+            'attributes_bWCSCStreetCleansingDefectSizeOfIssue_5e21b5ccca31500d1c836be0' => ['5e1f1bf0ca31500c541f82cb'],
+            'attributes_bWCSCStreetCleansingDefectJobType_5e21b5adca31500d1c836bc9' => ['5e2179a3ca315012d022222'],
+            'attributes_bWCSCStreetCleansingDefectFullDetails_5e21b587ca31500cc0a2df3a' => "title\n\ndescription",
+            'attributes_bWCSCStreetCleansingDefectLocality_5e6f97fe4cee260f90aca0d6' => ['5e16fa66ca314f0980300be5'],
+            'attributes_bWCSCStreetCleansingDefectFixMyStreetID_67654e2a1e4316383b73050f' => '123',
+        },
+        expected_design => 'designs_bWCSCStreetCleansingDefect_5e21a98bca315003e0983035',
+    },
 ) {
     subtest $test->{title} => sub {
         my $res = $endpoint->run_test_request(

t/open311/endpoint/bristol_alloy.yml

@@ -24,6 +24,7 @@
         "Blood": 1,
         "Dead animal": 1,
         "Dog fouling": 1,
+        "Glass (broken or not)": 1,
       },
   },
 
@@ -90,6 +91,7 @@
       'Blood': '5e21782dca315003e09804a2',
       'Dog fouling': '5e2179a3ca315012d0956667',
       'Abandoned private bike/scooter': '5e2179a3ca315012d099999',
+      'Glass (broken or not)': '5e2179a3ca315012d022222'
     },
   },