[Echo] Allow multiple reservation slots.

Author: dracos

perllib/Integrations/Echo.pm

@@ -177,7 +177,7 @@ sub PostEvent {
         EventObjects => { EventObject => $source },
         EventTypeId => $args->{event_type},
         ServiceId => $args->{service},
-        $args->{reservation} ? (TaskReservations => [ { 'msArray:string' => $args->{reservation} } ]) : (),
+        $args->{reservation} ? (TaskReservations => [ map { { 'msArray:string' => $_ } } @{$args->{reservation}} ]) : (),
     );
     $self->call('PostEvent', event => $data);
 }

perllib/Open311/Endpoint/Integration/Echo.pm

@@ -463,7 +463,7 @@ sub process_service_request_args {
        $request->{guid} = $guid;
     }
     if (my $reservation = $args->{attributes}{reservation}) {
-       $request->{reservation} = $reservation;
+       $request->{reservation} = [ split /::/, $reservation ];
     }
 
     return $request;

t/open311/endpoint/sutton.t

@@ -66,9 +66,11 @@ $soap_lite->mock(call => sub {
             is $event_type, 3145;
             is $service_id, 944;
             is $guid, 'd5f79551-3dc4-11ee-ab68-f0c87781f93b';
-            my $reservation = ${$params[5+$offset]->value}->value->value;
-            is $reservation->name, 'string';
-            is $reservation->value, 'reservation==';
+            my @reservations = ${$params[5+$offset]->value}->value->value;
+            is $reservations[0]->name, 'string';
+            is $reservations[0]->value, 'reservation1==';
+            is $reservations[1]->name, 'string';
+            is $reservations[1]->value, 'reservation2==';
             my @data = ${$params[$offset]->value}->value->value;
             is scalar @data, 0;
         } elsif ($client_ref eq 'LBS-2000123') {
@@ -147,7 +149,7 @@ subtest "POST missed mixed+paper OK" => sub {
         'attribute[fixmystreet_id]' => 2000125,
         'attribute[service_id]' => 944,
         'attribute[GUID]' => 'd5f79551-3dc4-11ee-ab68-f0c87781f93b',
-        'attribute[reservation]' => 'reservation==',
+        'attribute[reservation]' => 'reservation1==::reservation2==',
     );
     ok $res->is_success, 'valid request'
         or diag $res->content;