Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BANES][Open311] Create a multi with a Passthrough #399

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[BANES][Open311] Create a multi with a Passthrough #399

wants to merge 4 commits into from

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Mar 3, 2025 •
edited
Loading

Makes BANES a multi.

Passthrough will receive all reports with an email address in them and any others will go to Confirm.

https://github.com/mysociety/societyworks/issues/4746

@MorayMySoc MorayMySoc requested review from dracos and removed request for dracos March 3, 2025 11:34
@mysociety-pusher mysociety-pusher force-pushed the BNS172-4830-create-multi branch from ffc9ea8 to 5a526ea Compare March 4, 2025 16:56
@MorayMySoc MorayMySoc requested a review from dracos March 4, 2025 17:04
dracos
dracos requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tiny comments, looks good, thanks for sorting out the prefix stuff and getting the bearer stuff working :)

@MorayMySoc MorayMySoc requested a review from dracos March 7, 2025 18:32
dracos
dracos approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@MorayMySoc
Copy link
Contributor Author

Fixup added after conversation with @dracos https://mysociety.slack.com/archives/D02AQFQV535/p1741624818093619 regarding the service_code representing the confirm code

@MorayMySoc MorayMySoc requested a review from dracos March 10, 2025 17:37
@MorayMySoc
[Open311] Remove trailing whitespace
13eafe9
@MorayMySoc
[Open311][BANES] Makes Banes a multi and adds Passthrough
90955cb 
Passthrough will receive all reports with an email address
in them and any others will go to Confirm.

mysociety/societyworks#4746
@mysociety-pusher mysociety-pusher force-pushed the BNS172-4830-create-multi branch from 33cb881 to 90955cb Compare March 11, 2025 09:45
@MorayMySoc MorayMySoc requested a review from dracos March 12, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracos dracos dracos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MorayMySoc @dracos