[#1663] Add additional routes for /help/house_rules

[mdeuk]

Relevant issue(s)

#1663

What does this do?

This adds a new route which allows for the /help/house_rules page to be accessed using different paths.

Why was this needed?

Chat on #1663, and predecessors, has raised the issue of language.

Allowing more possibilities allows us to ensure that messages to users are easy to understand, as "house rules" may not mean something to many.

Implementation notes

The basic implementation isn't anything especially complex - it is a redirect to /help/house_rules.

We match :help_house_rules_resolve against a constraint. The following are accepted values:

• conditions_of_use
• site_rules
• terms_and_conditions
• terms_of_service
• terms_of_use
• the_legal_stuff
• the_rules

This doesn't change the existing route for /help/house_rules, as whilst it is trivial to include that here, it is a bit less elegant ¹.

Screenshots

N/A

Notes to reviewer

I've tested this on a sandbox install (running 0.43.0.0 / rails 7.0.4.3 / ruby 3.2.1) and didn't encounter any problems.

Footnotes

1. not that this is elegant… but, it prevents a slight nuisance in regard to how we render the sidebar (e.g. not rendering a clickable 'house rules' link when we don't have to). ↩

[mdeuk]

Related:

• Add paragraph about abuse to the 'house rules' / change house rules phrasing #1665

[garethrees]

Thanks for this, but I think we should instead resolve #1663 and then update the URL. If we start using a multitude of URLs it might get quite confusing (e.g. if we send a user a URL for "conditions of use" and then they try to find the page through browsing, they won't find it.) We'd also then have to consider whether to maintain these URLs over the long term, which while small, adds a difficult-to-resolve issue and a little more code complexity.