Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1973] Minor improvements to OSA content #1974

Merged
merged 4 commits into from
Mar 12, 2025
Merged

[#1973] Minor improvements to OSA content #1974

merged 4 commits into from
Mar 12, 2025

Conversation

mdeuk
Copy link
Collaborator

@mdeuk mdeuk commented Mar 11, 2025

Relevant issue(s)

#1973

What does this do?

This corrects a typo (CESA should be CSEA), and makes some slight changes to the copy, so that it flows a bit better. It also spells out CSEA, and references Ofcom with their common name.

Why was this needed?

The copy was good, but it did not flow very well on user's screens, so it looked a bit like a wall of text (within one!), and there were a couple of typos (ref #1973 (review)).

Additionally, we referred to Ofcom as "Office of Communications" - we should try and avoid govspeak here, and use the more common name.

Implementation notes

Nothing to note.

Screenshots

From To
Screenshot showing the original rendering of the #illegal copy on page Screenshot showing the proposed #illegal content, as shown in this PR

Notes to reviewer

The HTML on removing_information.html.erb is not consistently formatted. I've reformatted the bits in play here, but you might want to look at it more generally.

Copy link
Member

@garethrees garethrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@garethrees garethrees merged commit 70c2125 into master Mar 12, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants