fix(n8n-nodes-base): split build steps and increase memory limit to prevent OOM crashes #14570
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Review this PR on mrge.io |
![mrge-io[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| @@ -8,7 +8,10 @@ | |||
| "copy-nodes-json": "node scripts/copy-nodes-json.js .", | |||
| "dev": "pnpm watch", | |||
| "typecheck": "tsc --noEmit", | |||
| "build": "tsup --tsconfig tsconfig.build.json && pnpm copy-nodes-json && tsc-alias -p tsconfig.build.json && pnpm n8n-copy-static-files && pnpm n8n-generate-translations && pnpm n8n-generate-metadata", | |||
| "build": "pnpm build:ts && pnpm build:alias && pnpm build:meta", | |||
| "build:ts": "NODE_OPTIONS=--max-old-space-size=8192 tsup --tsconfig tsconfig.build.json", | |||
There was a problem hiding this comment.
Memory limit discrepancy between PR description (16384MB) and implementation (8192MB)
| @@ -8,7 +8,10 @@ | |||
| "copy-nodes-json": "node scripts/copy-nodes-json.js .", | |||
| "dev": "pnpm watch", | |||
| "typecheck": "tsc --noEmit", | |||
| "build": "tsup --tsconfig tsconfig.build.json && pnpm copy-nodes-json && tsc-alias -p tsconfig.build.json && pnpm n8n-copy-static-files && pnpm n8n-generate-translations && pnpm n8n-generate-metadata", | |||
| "build": "pnpm build:ts && pnpm build:alias && pnpm build:meta", | |||
| "build:ts": "NODE_OPTIONS=--max-old-space-size=8192 tsup --tsconfig tsconfig.build.json", | |||
There was a problem hiding this comment.
Environment variable syntax may not be cross-platform compatible
| @@ -8,7 +8,10 @@ | |||
| "copy-nodes-json": "node scripts/copy-nodes-json.js .", | |||
| "dev": "pnpm watch", | |||
| "typecheck": "tsc --noEmit", | |||
| "build": "tsup --tsconfig tsconfig.build.json && pnpm copy-nodes-json && tsc-alias -p tsconfig.build.json && pnpm n8n-copy-static-files && pnpm n8n-generate-translations && pnpm n8n-generate-metadata", | |||
| "build": "pnpm build:ts && pnpm build:alias && pnpm build:meta", | |||
| "build:ts": "NODE_OPTIONS=--max-old-space-size=8192 tsup --tsconfig tsconfig.build.json", | |||
There was a problem hiding this comment.
Watch mode command not updated with memory limits
n8n-assistant
bot
added
community
|
Hey @LcCompany, Thanks for the PR, We have created "GHC-1545" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by mrge
Split the n8n-nodes-base build process into separate steps with increased memory limits to prevent out-of-memory crashes. This change improves build stability in low-memory environments like CI pipelines and self-hosted instances with 2-4 GB of RAM.
Bug Fixes
ERR_WORKER_OUT_OF_MEMORYerrors during builds on memory-constrained systems.--max-old-space-size=8192flag to Node.js options for critical build steps.Refactors
Splits the
n8n-nodes-basebuild script into separate steps (tsup,tsc-alias, metadata generation), each with an increased Node.js heap size (--max-old-space-size=16384).This resolves
ERR_WORKER_OUT_OF_MEMORYerrors that occur during build on low-memory environments such as Render, CI/CD pipelines, and self-hosted instances with 2–4 GB of RAM.How to test:
pnpm run buildin the root monorepo on a machine with limited memory (2–4 GB).packages/nodes-basewithout memory-related crashes.dist/directory remains the same.No changes to runtime logic. This improves developer experience and build stability.
Review / Merge checklist:
✅ PR title and summary are descriptive.
✅ Tests included (no logic changes — build-only).
✅ PR Labeled with release/backport: likely not urgent in this case