Skip to content

fix(n8n-nodes-base): split build steps and increase memory limit to prevent OOM crashes #14570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+4 −1
Open

fix(n8n-nodes-base): split build steps and increase memory limit to prevent OOM crashes #14570

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45e88e5
Update package.json
LcCompany Apr 12, 2025
954bbff
Update package.json split
LcCompany Apr 12, 2025
a8ae87b
Merge branch 'n8n-io:master' into master
LcCompany Apr 22, 2025
5460207
Merge branch 'n8n-io:master' into master
LcCompany Apr 23, 2025
2e3c9bc
Merge branch 'n8n-io:master' into master
LcCompany Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/nodes-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"copy-nodes-json": "node scripts/copy-nodes-json.js .",
"dev": "pnpm watch",
"typecheck": "tsc --noEmit",
"build": "tsup --tsconfig tsconfig.build.json && pnpm copy-nodes-json && tsc-alias -p tsconfig.build.json && pnpm n8n-copy-static-files && pnpm n8n-generate-translations && pnpm n8n-generate-metadata",
"build": "pnpm build:ts && pnpm build:alias && pnpm build:meta",
"build:ts": "NODE_OPTIONS=--max-old-space-size=8192 tsup --tsconfig tsconfig.build.json",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memory limit discrepancy between PR description (16384MB) and implementation (8192MB)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Environment variable syntax may not be cross-platform compatible

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch mode command not updated with memory limits

"build:alias": "NODE_OPTIONS=--max-old-space-size=8192 tsc-alias -p tsconfig.build.json",
"build:meta": "pnpm copy-nodes-json && pnpm n8n-copy-static-files && pnpm n8n-generate-translations && pnpm n8n-generate-metadata",
"format": "biome format --write .",
"format:check": "biome ci .",
"lint": "eslint nodes credentials utils test --quiet && node ./scripts/validate-load-options-methods.js",
Expand Down