feat(core): Enable insights for sqlite legacy #14606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
![mrge-io[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
guillaumejacquart
force-pushed
the
pay-insights-enabled-sqlite-legacy
branch
from
06121f9 to
ee90bdb
Compare
ivov
reviewed
Apr 22, 2025
packages/cli/src/modules/insights/__tests__/insights.pre-init.test.ts
Outdated
Show resolved
Hide resolved
MarcL
approved these changes
Apr 22, 2025
|
✅ All Cypress E2E specs passed |
guillaumejacquart
added a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit 88ed7be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before setting up buffering and flushing mechanism to save insights data, we experienced errors on saving insights, and mismatch between executions and insights data when using legacy SQLite driver (poolSize == 0).
Since buffer / flush has been setup, we could not reproduce this error.
Thus we suggest to enable insights even for legacy SQLite driver
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)