-
Notifications
You must be signed in to change notification settings - Fork 22.9k
fix(Google Sheets Trigger Node): Filter by first data row on rowAdded
event
#14731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Google Sheets Trigger Node): Filter by first data row on rowAdded
event
#14731
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
…rst-data-row-not-working
…rst-data-row-not-working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 3 issues across 2 files. View them in mrge.io
packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some touch ups. Beyond that, it looks good :)
packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts
Outdated
Show resolved
Hide resolved
…rst-data-row-not-working
✅ All Cypress E2E specs passed |
Summary
Update the Google Sheets Trigger Node to filter out rows on
rowAdded
event, based on "Header Row" and "First Data Row" when "Range Definition: Specify Range (Rows)" is selectedRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2516/community-issue-google-sheets-first-data-row-not-working
Closes #13322
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)