Skip to content

fix(Google Sheets Trigger Node): Filter by first data row on rowAdded event #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RomanDavydchuk
Copy link
Contributor

@RomanDavydchuk RomanDavydchuk commented Apr 18, 2025

Summary

Update the Google Sheets Trigger Node to filter out rows on rowAdded event, based on "Header Row" and "First Data Row" when "Range Definition: Specify Range (Rows)" is selected

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2516/community-issue-google-sheets-first-data-row-not-working

Closes #13322

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ase/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts 87.50% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 18, 2025
@RomanDavydchuk RomanDavydchuk marked this pull request as ready for review April 18, 2025 11:21
@dana-gill dana-gill self-requested a review April 18, 2025 11:24
Copy link

@mrge-io mrge-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 3 issues across 2 files. View them in mrge.io

Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some touch ups. Beyond that, it looks good :)

Copy link
Contributor

✅ All Cypress E2E specs passed

@RomanDavydchuk RomanDavydchuk merged commit 1593fe3 into master Apr 22, 2025
35 checks passed
@RomanDavydchuk RomanDavydchuk deleted the node-2516-community-issue-google-sheets-first-data-row-not-working branch April 22, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sheets First Data Row not working
2 participants