-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically generate declaration files #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshvermaire doesn't seem like the added declarations are of much consequence, since the publicly facing names seem to alias to them e.g. iNami. Does this seem right to you?
I made a script to check the differences between the two, this is what I found: The This
I'm assuming it's ok if the type declarations that were missing from the main branch are included in new builds, but if we want to formally exclude those we would need to add that. |
Here's a link to the script if you ever need it: https://gist.github.com/joshvermaire/15ccd0e0e88baaba90daac76be5ccfd5 You can run it via |
Yes, I think that's right. I don't see it as an issue. In the future if you wanted to 'clean things up' we could make some changes to exclude them, but I don't see it causing any issues |
Few things of note:
NamiBridge
andNamiManager
and other interfaces likeINami
,INamiCustomerManager
, etc. If these aren't expected we may need make some modifications if they're not wanted to be in the declaration output.ICampaignManager
aren't exportedtypes.d.ts
file