Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC-5315: add missing fields in NamiCampaign and NamiPurchase #338

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

cp-sumi-k
Copy link
Contributor

@cp-sumi-k cp-sumi-k commented Aug 12, 2024

  • NamiCampaign:
    • Remove id and add name
    • Add form_factors and external_segment_id
  • NamiPurchase:
    • Add purchaseToken

@namidan In iOS and Android's NamiCampaign type, I have seen they are using external_segment, but we are getting external_segment_id from API response. Should we need to change from external_segment_id to external_segment ?

@cp-sumi-k cp-sumi-k marked this pull request as draft August 12, 2024 06:04
@cp-sumi-k cp-sumi-k marked this pull request as ready for review August 21, 2024 07:30
@namidan
Copy link
Contributor

namidan commented Aug 21, 2024

@cp-sumi-k yes we should for consistency.

@cp-sumi-k
Copy link
Contributor Author

@namidan The Mobile team is expecting an external_segment field from the API response, but the API response has an external_segment_id field not external_segment, Wouldn't there be conflicts in mobile SDKs?

@cp-sumi-k cp-sumi-k requested a review from namidan September 3, 2024 09:08
@namidan
Copy link
Contributor

namidan commented Sep 4, 2024

@namidan The Mobile team is expecting an external_segment field from the API response, but the API response has an external_segment_id field not external_segment, Wouldn't there be conflicts in mobile SDKs?

Go ahead and use external_segment, we will adjust the API response

@namidan namidan merged commit 39107ba into main Sep 5, 2024
6 of 7 checks passed
@namidan namidan deleted the NC-5315-update-rn-sdk branch September 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants