Skip to content

[Enh]: Include tests in source distribution #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mgorny opened this issue Mar 25, 2025 · 0 comments · May be fixed by #2285
Open

[Enh]: Include tests in source distribution #2284

mgorny opened this issue Mar 25, 2025 · 0 comments · May be fixed by #2285
Labels
build tests

Comments

@mgorny
Copy link
Contributor

mgorny commented Mar 25, 2025

We would like to learn about your use case. For example, if this feature is needed to adopt Narwhals in an open source project, could you please enter the link to it below?

I am adding Narwhals package to Gentoo Linux. It works great, and working with is a pleasure!

Please describe the purpose of the new feature or describe the problem to solve.

For Gentoo packages, we really want to run tests as part of the package building/install process. While using GitHub archives is acceptable, we strongly prefer using source distributions from PyPI, and this is especially important now that PyPI supports signed attestations.

Suggest a solution if possible.

Include all the files needed to run tests in the source distribution.

If you have tried alternatives, please describe them below.

The alternative is to download autogenerated GitHub archives. However, unlike source distributions, they are not signed and they technically don't have 100% guarantee that the file checksum won't change in the future.

Additional information that may help us understand your needs.

No response
mgorny added a commit to mgorny/narwhals that referenced this issue Mar 25, 2025
@mgorny
build: Include tests in source distributions
038f10b 
Include test files in the source distribution, to make it possible
to run them while repackaging from sources.  This permits Linux
distributions to use signed PyPI release artficats rather than having
to use the git repository directly.

Fixes narwhals-dev#2284
mgorny added a commit to mgorny/narwhals that referenced this issue Mar 25, 2025
@mgorny
build: Include tests in source distributions
9f896f7 
Include test files in the source distribution, to make it possible
to run them while repackaging from sources.  This permits Linux
distributions to use signed PyPI release artficats rather than having
to use the git repository directly.

Fixes narwhals-dev#2284
@mgorny mgorny linked a pull request Mar 25, 2025 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Include tests in source distributions mgorny/narwhals
2 participants
@mgorny @dangotbanned