-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local DynamoDB streams Integration #2918
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
========================================
- Coverage 6.30% 6.29% -0.01%
========================================
Files 175 175
Lines 4348 4353 +5
Branches 474 474
========================================
Hits 274 274
- Misses 4072 4077 +5
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a response there, but I am going to track this as a further enhancement to the plugin. It requires more work, but doesn't hold up reaching this goal |
We need to add some more items for this to our development instructions, don't we? |
Yea, I can update the docs for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do the changes in this file have to do with the DynamoDB simulator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you trigger the lambda, it tries to send an email, which can fail if either the template is not defined (which it isnt on local, thats a sandbox thing I believe) or if the user doesn't have valid credentials and pointing to a matching env (which would be the case for running playwright tests)
Also I am working on resolving the currently failing tests locally, should have that out later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're still working on fixing the playwright tests?
Also, please resolve merge conflicts. |
b42b690
to
1fe3806
Compare
1fe3806
to
4ba1481
Compare
Install actual package cleanup remove comment Update docs for config updates Trying a fix for tests and move the dependency
4ba1481
to
a837681
Compare
Resolves #2804
This PR adds @nasa-gcn/architect-plugin-dynamodb-local-streams as a dependency, updates the app.arc, and adds a few other changes to configure the testing environment to work both with a local docker instance for dynamodb and the table-streams functionality.
There is a known issue with the docker dynamodb local image that I have described in the readme of this package. https://github.com/nasa-gcn/architect-plugin-dynamodb-local-streams
But it does not impede our development. In short, the first invocation for each stream will throw a
TrimmedDataAccessException
. This is expected and is intentionally suppressed and logged in the console. Subsequent invocations run as expected.In order to fully set this up, you must add the following to your
.env
:To Test:
Current Streams that can be invoked:
SYNONYM
feature flag.