Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local DynamoDB streams Integration #2918
base: main
Are you sure you want to change the base?
Local DynamoDB streams Integration #2918
Changes from all commits
150a008
a837681
e9ca2ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do the changes in this file have to do with the DynamoDB simulator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you trigger the lambda, it tries to send an email, which can fail if either the template is not defined (which it isnt on local, thats a sandbox thing I believe) or if the user doesn't have valid credentials and pointing to a matching env (which would be the case for running playwright tests)
Also I am working on resolving the currently failing tests locally, should have that out later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're still working on fixing the playwright tests?
Check warning on line 23 in app/lib/email.server.ts
app/lib/email.server.ts#L23
Check warning on line 83 in app/lib/email.server.ts
app/lib/email.server.ts#L82-L83
Check warning on line 85 in app/lib/email.server.ts
app/lib/email.server.ts#L85
Check warning on line 132 in app/lib/email.server.ts
app/lib/email.server.ts#L131-L132
Check warning on line 136 in app/lib/email.server.ts
app/lib/email.server.ts#L136