Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile on Clojure 1.9.0-alpha12 #18

Open
AdamFrey opened this issue Sep 19, 2016 · 1 comment
Open

Doesn't compile on Clojure 1.9.0-alpha12 #18

AdamFrey opened this issue Sep 19, 2016 · 1 comment

Comments

@AdamFrey
Copy link

The new alpha releases of Clojure do compile-time checking for core macros like ns, defn

Trying to require clj-tagsoup on Clojure 1.9.0-alpha12 throws the following big error and shows that the problem is actually when it trying to require clojure/data/xml.clj

clojure.lang.Compiler$CompilerException: 
clojure.lang.ExceptionInfo: Call to clojure.core/defn did not conform to spec:
In: [1 0] val: ({:keys (attrs)} writer) fails spec: :clojure.core.specs/arg-list at: [:args :bs :arity-1 :args] predicate: (cat :args (* :clojure.core.specs/binding-form) :varargs (? (cat :amp #{(quote &)} :form :clojure.core.specs/binding-form))),  Extra input
In: [1 0] val: {:keys (attrs)} fails spec: :clojure.core.specs/arg-list at: [:args :bs :arity-n :bodies :args] predicate: vector?
:clojure.spec/args  (write-attributes [{:keys (attrs)} writer] (doseq [[k v] attrs] (if (namespace k) (.writeAttribute writer (str (namespace k)) (name k) (str v)) (.writeAttribute writer (name k) (str v))))) 
...
compiling:(clojure/data/xml.clj:30:1)

The version of clojure/data/xml that clj-tagsoup is using contains the broken code and is also quite old. Bumping the clojure/data/xml dependency should fix the problem.

@nathell
Copy link
Owner

nathell commented Sep 28, 2016

Thanks for reporting this, I'll be fixing it in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants