Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JNats and Server Runner #73

Merged
merged 3 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {

}

def jarVersion = "2.0.4"
def jarVersion = "2.1.0"
group = 'io.nats'

def isMerge = System.getenv("BUILD_EVENT") == "push"
Expand All @@ -33,14 +33,14 @@ repositories {

dependencies {

implementation 'io.nats:jnats:2.17.2'
implementation 'io.nats:jnats:2.20.5'
implementation("com.fasterxml.jackson.core:jackson-core:2.14.2")
implementation("io.netty:netty-handler:4.1.97.Final")
implementation(platform("io.vertx:vertx-stack-depchain:4.5.1"))
implementation("io.vertx:vertx-core")
implementation("io.netty:netty-resolver-dns-native-macos:4.1.80.Final:osx-x86_64")
testImplementation("io.vertx:vertx-junit5")
testImplementation 'io.nats:jnats-server-runner:1.2.5'
testImplementation 'io.nats:jnats-server-runner:2.0.0'
}

test {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/nats/client/impl/VertxDispatcher.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class VertxDispatcher extends NatsDispatcher {

VertxDispatcher(NatsConnection conn, MessageHandler handler, ContextInternal context) {
super(conn, handler);
vertxIncoming = new VertxDispatcherMessageQueue(this, context);
vertxIncoming = new VertxDispatcherMessageQueue(this, context, conn);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class VertxDispatcherMessageQueue extends MessageQueue {
private final VertxDispatcher dispatcher;
private final ContextInternal context;

VertxDispatcherMessageQueue(VertxDispatcher dispatcher, ContextInternal context) {
super(true);
VertxDispatcherMessageQueue(VertxDispatcher dispatcher, ContextInternal context, NatsConnection conn) {
super(true, conn.getOptions().getRequestCleanupInterval());
this.dispatcher = dispatcher;
this.context = context;
}
Expand Down Expand Up @@ -65,11 +65,6 @@ void poisonTheQueue() {
throw new IllegalStateException("poisonTheQueue not used.");
}

@Override
boolean offer(NatsMessage msg) {
throw new IllegalStateException("offer not used.");
}

@Override
NatsMessage poll(Duration timeout) throws InterruptedException {
return super.poll(timeout);
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/io/nats/vertx/NatsClientTest.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.nats.vertx;

import io.nats.NatsServerRunner;
import io.nats.client.*;
import io.nats.client.api.StorageType;
import io.nats.client.api.StreamConfiguration;
Expand All @@ -11,7 +12,6 @@
import io.vertx.core.Handler;
import io.vertx.core.Vertx;
import io.vertx.junit5.VertxExtension;
import nats.io.NatsServerRunner;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/nats/vertx/NatsSimplePerfTest.java
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package io.nats.vertx;

import io.nats.NatsServerRunner;
import io.nats.client.*;
import io.nats.client.api.StorageType;
import io.nats.client.api.StreamConfiguration;
import io.nats.client.api.StreamInfo;
import io.vertx.core.Future;
import io.vertx.core.Vertx;
import nats.io.NatsServerRunner;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -40,7 +40,7 @@ public void after() throws Exception {

@BeforeEach
public void setup() throws Exception {
natsServerRunner = new NatsServerRunner(0, false, true);
natsServerRunner = NatsServerRunner.builder().jetstream().build();
Thread.sleep(1);


Expand Down
19 changes: 13 additions & 6 deletions src/test/java/io/nats/vertx/NatsStreamTest.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.nats.vertx;

import io.nats.NatsServerRunner;
import io.nats.client.*;
import io.nats.client.api.StorageType;
import io.nats.client.api.StreamConfiguration;
Expand All @@ -8,7 +9,6 @@
import io.nats.client.impl.NatsMessage;
import io.vertx.core.Future;
import io.vertx.core.Vertx;
import nats.io.NatsServerRunner;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand All @@ -34,11 +34,18 @@ public class NatsStreamTest {

@AfterEach
public void after() throws Exception {
if (nc != null)
nc.close();

if (natsServerRunner != null)
natsServerRunner.close();
try {
if (nc != null) {
nc.close();
}
}
catch (Exception ignore) {}
try {
if (natsServerRunner != null) {
natsServerRunner.close();
}
}
catch (Exception ignore) {}
}

int port;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/nats/vertx/TestUtils.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package io.nats.vertx;

import io.nats.NatsServerRunner;
import io.nats.client.*;
import io.nats.client.support.Status;
import io.vertx.core.Future;
import io.vertx.core.Handler;
import io.vertx.core.Vertx;
import nats.io.NatsServerRunner;

import java.time.Duration;
import java.util.concurrent.CountDownLatch;
Expand Down Expand Up @@ -100,7 +100,7 @@ public static NatsClient natsClient(int port, Vertx vertx, Handler<Throwable> ex

public static NatsServerRunner startServer() throws Exception {
NatsServerRunner.setDefaultOutputLevel(Level.WARNING);
NatsServerRunner natsServerRunner = new NatsServerRunner(0, false, true);
NatsServerRunner natsServerRunner = NatsServerRunner.builder().jetstream().build();

int port = natsServerRunner.getPort();
for (int i = 0; i < 100; i++) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.nats.vertx.impl;


import io.nats.NatsServerRunner;
import io.nats.client.*;
import io.nats.client.api.StorageType;
import io.nats.client.api.StreamConfiguration;
Expand All @@ -10,7 +11,6 @@
import io.vertx.core.Vertx;
import io.vertx.junit5.VertxExtension;
import io.vertx.junit5.VertxTestContext;
import nats.io.NatsServerRunner;
import org.junit.jupiter.api.*;
import org.junit.jupiter.api.extension.ExtendWith;

Expand Down
Loading