[FIX] simpler way to noResolve

Author: aricart

nats-base-client/core.ts

@@ -1411,10 +1411,12 @@ export interface ConnectionOptions {
   noAsyncTraces?: boolean;
 
   /**
-   * When true, the connect function will remove any name resolution provided by
-   * the transport. In some environments (browsers) this is a no-op option.
+   * When false, the connect function will not perform any hostname resolution. Note that
+   * by default this option will be true if the client supports hostname resolution.
+   * Note that on clients that don't supported (mainly the websocket client, setting this
+   * option to true, will throw an exception as this option is not available.
    */
-  noResolve?: boolean;
+  resolve?: boolean;
 }
 
 /**

nats-base-client/options.ts

@@ -135,6 +135,12 @@ export function parseOptions(opts?: ConnectionOptions): ConnectionOptions {
     }
   }
 
+  // if not set - we set it
+  if (options.resolve === undefined) {
+    // set a default based on whether the client can resolve or not
+    options.resolve = typeof getResolveFn() === "function";
+  }
+
   if (options.resolve) {
     if (typeof getResolveFn() !== "function") {
       throw new NatsError(

nats-base-client/protocol.ts

@@ -594,8 +594,8 @@ export class ProtocolHandler implements Dispatcher<ParserEvent> {
   }
 
   async _doDial(srv: Server): Promise<void> {
-    const resolve = this.options.noResolve !== true;
-    const alts = this.options.noResolve === true ? [srv] : await srv.resolve({
+    const { resolve } = this.options;
+    const alts = await srv.resolve({
       fn: getResolveFn(),
       debug: this.options.debug,
       randomize: !this.options.noRandomize,

tests/basics_test.ts

@@ -1437,7 +1437,7 @@ Deno.test("basics - noResolve", async () => {
   const nci = await connect({
     servers: "connect.ngs.global",
     authenticator: jwtAuthenticator(token),
-    noResolve: true,
+    resolve: false,
   }) as NatsConnectionImpl;
 
   const srv = nci.protocol.servers.getCurrentServer();