Skip to content

Commit 8b7c1f4

Browse files
authored
Merge pull request #707 from nats-io/fix-706
[FIX] [JS] [KV] fixed an issue where `maxBucketSize` (deprecated option) overrode `max_bytes`
2 parents 6d63b5c + c507edd commit 8b7c1f4

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

jetstream/kv.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export function defaultBucketOpts(): Partial<KvOptions> {
108108
replicas: 1,
109109
history: 1,
110110
timeout: 2000,
111-
maxBucketSize: -1,
111+
max_bytes: -1,
112112
maxValueSize: -1,
113113
codec: NoopKvCodecs(),
114114
storage: StorageType.File,

jetstream/tests/kv_test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2164,3 +2164,14 @@ Deno.test("kv - watcher on server restart", async () => {
21642164
await d;
21652165
await cleanup(ns, nc);
21662166
});
2167+
2168+
Deno.test("kv - maxBucketSize doesn't override max_bytes", async () => {
2169+
let { ns, nc } = await setup(
2170+
jetstreamServerConf({}),
2171+
);
2172+
const js = nc.jetstream();
2173+
const kv = await js.views.kv("A", { max_bytes: 100 });
2174+
const info = await kv.status();
2175+
assertEquals(info.max_bytes, 100);
2176+
await cleanup(ns, nc);
2177+
});

0 commit comments

Comments
 (0)